-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page List: Add typography supports #43316
Conversation
I retested this and it all seems to be working as expected, but I wasn't able to replicate your setup with the navigation block @carolinan - how do you add a Page list block as a dropdown in a Nav menu the way you have it? |
Create a few pages with and without child pages on the test install. Or import the theme test data. In the block editor or site editor, add a navigation block. Select the navigation block. The block inserter should show a reduced number of items: Select the page list block. It should now be visible both in the editor and in the list view, as an inner block of the navigation block. |
🤦 ! thanks @carolinan, was overlooking the good old-fashioned I was able to replicate the same issue you are having with padding disappearing on the dropdown menu page list on this branch - works as expected on trunk. Will try and take a closer look at why sometime this week. |
It happens even if I do not make any changes to the typography settings 🤔 |
27e43de
to
62b950c
Compare
@carolinan I rebased this and retested it and I am not seeing the lack of padding issue now: are you able to give it another go please when you have a minute please and see if it is resolved for you as well now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In block themes (Twenty Twenty-Three, empty theme): The spacing is correct in the editor and front in the standalone block, the navigation block, and navigation block overlay.
Not blockers:
Twenty Nineteen:
The spacing is correct in the editor and front.
The exception is on the front, in the navigation block overlay, where the spacing is exceptionally large and a 2em blockgap is applied. This is unrelated to this PR.
Twenty Sixteen:
The page list is broken when placed in the navigation block: there is too much spacing between the submenus, so the "show menu items on hover" stops working. I believe this is a theme issue unrelated to this PR.
c1d5f80
to
f653e97
Compare
Co-authored-by: Glen Davies <glen.davies@automattic.com>
Related:
What?
Adds all typography support to the Page List block.
Why?
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-08-17.at.7.48.45.pm.mp4