Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover: make more reactive to prop changes, avoid unnecessary updates #43335

Merged
merged 10 commits into from
Aug 31, 2022
Merged

Popover: make more reactive to prop changes, avoid unnecessary updates #43335

merged 10 commits into from
Aug 31, 2022

Commits on Aug 31, 2022

  1. Arow ref as a callback ref calling update()

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a6bcdcf View commit details
    Browse the repository at this point in the history

  2. Reference ref and ownerDoc as internal state, compute under the same … 

    …useLayoutEffect
    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8d83ab5 View commit details
    Browse the repository at this point in the history

  3. use whileElementsMounted for auto-updating reference

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    950bf86 View commit details
    Browse the repository at this point in the history

  4. Extract getReferenceOwnerDocument amd getReferenceElement to separate… 

    … utils functions
    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    f8d83b7 View commit details
    Browse the repository at this point in the history

  5. Move useLayoutEffect after calling floating ui, remove need for refer… 

    …enceElement to be stored in state
    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1a09739 View commit details
    Browse the repository at this point in the history

  6. Animate only when opening the popover

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ca84935 View commit details
    Browse the repository at this point in the history

  7. Storybook: improve examples

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    c1a49f6 View commit details
    Browse the repository at this point in the history

  8. CHANGELOG

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    29936a5 View commit details
    Browse the repository at this point in the history

  9. scrollIntoView instead of focus

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    41404c0 View commit details
    Browse the repository at this point in the history

  10. Add iframeOffset to arrow position

    @ciampo
    ciampo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1de9502 View commit details
    Browse the repository at this point in the history