-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Excerpt: Add missing typography supports #43341
Post Excerpt: Add missing typography supports #43341
Conversation
The text decoration option does not work/ apply to the read more link. |
Oh, that's a good point. I think it's a tricky one with this block because it isn't a separate inner block, but the field can be edited via the Because text decoration works additively (i.e. we can add styles but can't remove them via the control), I think I'd lean toward including text decoration as-is for this one, since folks can already set strike-through for the read more link via the toolbar controls when they edit the text, and by default the link will have underline style already in place. |
I disagree only because it is not clear to users why the setting does not remove the underline. I think it will introduce more confusion. |
I tend towards merging this as is as well. The potential for confusion exists both with typographic design tools missing and the edge case relating to the read more link. Given text decoration will be seldom used and even more seldom used for the link and isn't displayed by default, I think we can accept this for now until the read more link is made an inner block. I'll add a follow-up to possibly make the read more link within the excerpt an inner block. I'll also hold off merging until next week to give space for any further opinions, feedback, or ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working nicely for me, and it sounds like we can look into the read more link potentially being an inner block separately. I'll merge this in now and update the tracking issue.
Related:
What?
Adds missing typography supports to the Post Excerpt block.
Why?
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-08-18.at.10.36.16.am.mp4