Minor code tweaks/optimizations (PHP) #43375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
commented
Aug 18, 2022
Comment on lines
-15
to
-17
| // Determine if any border related features are supported. | ||
| $has_border_support = block_has_support( $block_type, array( '__experimentalBorder' ) ); | ||
| $has_border_color_support = gutenberg_has_border_feature_support( $block_type, 'color' ); |
There was a problem hiding this comment.
These are only used once, so we don't need to assign them to a var.
aristath
commented
Aug 18, 2022
| @@ -48,9 +44,7 @@ function gutenberg_apply_border_support( $block_type, $block_attributes ) { | |||
| return array(); | |||
| } | |||
|
|
|||
| $sides = array( 'top', 'right', 'bottom', 'left' ); | |||
There was a problem hiding this comment.
$sides is only used once, no need to assign it to a var
aristath
commented
Aug 18, 2022
| $color_support = false; | ||
| if ( property_exists( $block_type, 'supports' ) ) { | ||
| $color_support = _wp_array_get( $block_type->supports, array( 'color' ), false ); | ||
| } | ||
| $color_support = property_exists( $block_type, 'supports' ) ? _wp_array_get( $block_type->supports, array( 'color' ), false ) : false; |
skorasaurus
added
the
[Type] Code Quality
ntsekouras
approved these changes
Aug 29, 2022
85 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Just some minor code optimizations. Details in comments for each change.