Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraph: Add spacing block supports #43455

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Paragraph: Add spacing block supports #43455

merged 1 commit into from
Aug 22, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 21, 2022 •
edited
Loading

Related:

What?

Add padding and margin support to the Paragraph block.

Why?

Back in 2021, I proposed adding margin support to paragraph blocks. See the discussion in #37300. Well, we have come a long way since then, and given the broader effort to standardize spacing support across blocks, now is the time to add this to paragraphs as well. Also, block theme designers around the world will rejoice 😂

I have closed #37300 in favor of this PR so we can address padding as well.

How?

Added the relevant block supports in block.json

Testing Instructions

  1. Insert a Paragraph block.
  2. Confirm that the dimensions control panel is there and there are no defaults.
  3. Add padding and margin.

Screenshots or screencast

paragraph-spacing

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Paragraph Affects the Paragraph Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 21, 2022
@ndiego ndiego self-assigned this Aug 21, 2022
@ndiego ndiego mentioned this pull request Aug 21, 2022
Closed
7 tasks
glendaviesnz
glendaviesnz approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well from me on post editor and global styles

@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 22, 2022
Open
@glendaviesnz glendaviesnz merged commit 5e9f8d2 into WordPress:trunk Aug 22, 2022
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 22, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glendaviesnz glendaviesnz glendaviesnz approved these changes

@ramonjd ramonjd Awaiting requested review from ramonjd

@aaronrobertshaw aaronrobertshaw Awaiting requested review from aaronrobertshaw

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@ndiego ndiego

Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.

Margin support for Paragraph blocks is desperately needed.
3 participants
@ndiego @glendaviesnz @femkreations