Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip navigation menu selector focus test #43507

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Unskip navigation menu selector focus test #43507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/e2e-tests/specs/editor/blocks/navigation.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,10 +1681,7 @@ Expected mock function not to be called but it was called with: ["POST", "http:/
);
} );

// Skip reason: running it in interactive works but selecting and
// checking for focus consistently fails in the test.
// eslint-disable-next-line jest/no-disabled-tests
it.skip( 'should always focus select menu button after item selection', async () => {
it( 'should always focus select menu button after item selection', async () => {
// Create some navigation menus to work with.
await createNavigationMenu( {
title: 'First navigation',
Expand Down Expand Up @@ -1712,7 +1709,7 @@ Expected mock function not to be called but it was called with: ["POST", "http:/
const theOption = await page.waitForXPath(
"//button[@aria-checked='false'][contains(., 'First navigation')]"
);
theOption.click();
await theOption.click();

// Once the options are closed, does select menu button receive focus?
const selectMenuDropdown2 = await page.$(
Expand Down