Layout: Fix blockGap output when using a falsy 0 value #43757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes an issue exposed by #43466 where block gap values of
0
applied at the individual block level would not be output in server-rendering due to them using a falsy value.Why?
Previously, custom values of
0
were being stored as0px
which is a non-falsy string. However,0
as a string is falsy in PHP so the output was being skipped.How?
Do a non-null check instead of a truthy check for blockGap before outputting the layout styles.
Testing Instructions
0
preset value.0
spacing is being applied between child elementsOr, test with the following block markup
Test block markup
Screenshots or screencast
With this PR applied, the output should look like the following: