-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout: Fix blockGap output when using a falsy 0 value #43757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
An existing feature does not function as intended
[Feature] Design Tools
Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
labels
Sep 1, 2022
andrewserong
added
the
Backport to Gutenberg Minor Release
Pull request that needs to be backported to a Gutenberg minor release
label
Sep 1, 2022
ramonjd
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
andrewserong
removed
the
Backport to Gutenberg Minor Release
Pull request that needs to be backported to a Gutenberg minor release
label
Sep 1, 2022
I've just removed the |
andrewserong
added
the
[Feature] Layout
Layout block support, its UI controls, and style output.
label
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Design Tools
Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
[Feature] Layout
Layout block support, its UI controls, and style output.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes an issue exposed by #43466 where block gap values of
0
applied at the individual block level would not be output in server-rendering due to them using a falsy value.Why?
Previously, custom values of
0
were being stored as0px
which is a non-falsy string. However,0
as a string is falsy in PHP so the output was being skipped.How?
Do a non-null check instead of a truthy check for blockGap before outputting the layout styles.
Testing Instructions
0
preset value.0
spacing is being applied between child elementsOr, test with the following block markup
Test block markup
Screenshots or screencast
With this PR applied, the output should look like the following: