List block: prevent error upon pasting when list is empty #43761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
ellatrix
reviewed
Sep 1, 2022
| @@ -25,7 +25,7 @@ export function createListBlockFromDOMElement( listElement ) { | |||
| const [ nestedList, ...nodes ] = children; | |||
|
|
|||
| const hasNestedList = | |||
| nestedList.tagName === 'UL' || nestedList.tagName === 'OL'; | |||
| nestedList?.tagName === 'UL' || nestedList?.tagName === 'OL'; | |||
There was a problem hiding this comment.
Strange how there's no e2e test catching this. Should we add one to test migration from an empty list? How come the integration deprecation tests are passing?
There was a problem hiding this comment.
Pushed one at aae4651 (it fails without this fix).
|
Size Change: +33 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Sep 1, 2022
|
This has been cherry-picked to the |
This was referenced Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43753