Fix: block styles preview is not displayed #43837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Sep 4, 2022
| @@ -27,7 +31,7 @@ function InserterPreviewPanel( { item } ) { | |||
| viewportWidth={ example?.viewportWidth ?? 500 } | |||
| blocks={ | |||
| example | |||
| ? getBlockFromExample( item.name, { | |||
| ? getBlockFromExample( name, { | |||
There was a problem hiding this comment.
This is a small improvement 👍
t-hamano
commented
Sep 4, 2022
| const isReusable = isReusableBlock( item ); | ||
| const hoveredItemBlockType = getBlockType( name ); | ||
| const example = item.example || hoveredItemBlockType.example; |
There was a problem hiding this comment.
As far as I know, it is not explicitly stated that the example can be used for block variations.
To clarify what this code is intended to do, should I leave any comments here?
There was a problem hiding this comment.
It might be worth adding a small comment to explain why you're checking for both, for sure 👍
t-hamano
added
[Type] Bug
|
Size Change: +1.08 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Sep 6, 2022
ramonjd
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
This is working well for me.
I think adding a comment to explain why the fallback example block exists would be a good idea before merge.
Code optimization mentioned in https://github.com/WordPress/gutenberg/pull/43837/files#r963186600 optional, probably not required.
|
Thanks for working on this. I think it could be a cleaner fix to add the That way every place the |
|
Thanks for the review!
I think this makes sense. |
|
Looks good to me too. Thanks for fixing the bug that I made 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ##43836
Follow-up on #42454
What?
This PR fixes a problem with block style previews not displaying properly.
Why?
In #42454, the block variation
exampleis now referenced to enable a preview of template parts.However, to preview regular block styles, the main block
examplemust be referenced.How?
If the
exampleof the block variation does not exist, theexampleof the main block is referenced. This will ensure that previews of block variations and block styles are displayed correctly.Testing Instructions
Open the Global Inserter and confirm that the template part preview is enabled as before.
Insert a block with a block style and confirm that the preview displays correctly when you mouse over the style button.