Preview tests: Wait for the post-status change #43874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: +1.95 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
Another difference I noticed in a successful test run trace, the "View Options" dropdown is closed. Probably closing on focus-outside doesn't work in every case. I'm considering adding logic to close it manually. |
Mamaduka
force-pushed
the
fix/flaky-preview-test
branch
from
b3cd1f6 to
3583885
Compare
|
@kevin940726, should we give this solution a try? |
kevin940726
reviewed
Sep 7, 2022
| ); | ||
|
|
||
| // Close "View" dropdown if open. | ||
| if ( await previewToggle.isVisible() ) { |
There was a problem hiding this comment.
I think the previewToggle will always be visible here unless we add [include-hidden] to the locator selector?
There was a problem hiding this comment.
Maybe we should assert expanded status. We only want to close this if it's expanded.
Edit: The "View" button doesn't have the aria-hidden attribute set.
There was a problem hiding this comment.
I think waiting for the status change might be enough in this case. Let's remove this visible check and merge this PR to test it out?
There was a problem hiding this comment.
Sounds good. Updated in ea84e04.
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR tries to fix #37976.
I'm having trouble reproducing failure locally, so this is a bit of a wild guess based on the traces I examined. A few examples I checked showed that post-status switching is still in flight when test types
Draft.It might be safer to wait for the actual status change before running the last part of the tests.
An example trace could be found here - https://github.com/WordPress/gutenberg/actions/runs/2969205018.
Use
npx playwright show-trace <path-to-trace-zip>for viewing them.Testing Instructions
Screenshots or screencast