Social Icons: Add missing padding support, update margin support #43885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
andrewserong
added
[Feature] Design Tools
|
Size Change: +26 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
LGTM 🎉
✅ Padding could be applied in editor, and showed correctly in fronted
✅ Padding could be added to Social Icons block in global styles and this was applied in site editor, post editor and frontend
✅ border-box was applied to wrapper in editor and frontend
|
Thanks for reviewing! I'll merge and update the tracking issue 👍 |
andrewserong
deleted the
update/social-links-to-add-missing-spacing-supports
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Add padding support for the Social Icons block, update margin to be all sides for consistency with other blocks.
Why?
To create consistency across blocks.
How?
block.jsonbox-sizing: border-boxrule so that the padding matches adjacent blocks like GroupTesting Instructions
Also, test in Global Styles as well.
Note: There is an outstanding issues with specificity of margin styles as raised in #43404 and discussed in comparable PRs (e.g. here: #43520 (review)) — the idea with this PR is to create consistency in the opt-ins, and for us to look into seeing if we can improve the margin specificity issues separately.
Screenshots or screencast