FontFamily: Fix server-side attribute registration via typography support #43937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Ensures the
fontFamily
attribute is registered for block types on the server side as well. This fixes a400
error when attempting to change the font family for a server-side rendered block in the editor e.g. Archives, Tag Cloud etc.Why?
The attribute registration should be there in the server-side typography block supports as per
fontSize
etc. Fixing this error also unlocks typography support adoption for server-side rendered blocks.How?
Adds
fontFamily
to the block type's attributes when the block has font family support.Testing Instructions
Screenshots or screencast
Screen.Recording.2022-09-07.at.5.59.50.pm.mp4
Screen.Recording.2022-09-07.at.6.00.33.pm.mp4