Add icons for different types of suggestions in LinkControl #43970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Link Editing
kevin940726
force-pushed
the
add/icons-for-link-control
branch
from
d5e505d
to
3fb7fae
Compare
|
Size Change: +1.96 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Sep 8, 2022
|
Nice one, thank you! |
getdave
approved these changes
Sep 8, 2022
packages/block-editor/src/components/link-control/search-item.js
Outdated
Show resolved
Hide resolved
getdave
reviewed
Sep 8, 2022
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add icons for different types of suggestions in
<LinkControl>.Why?
An idea grabbed from #38121 (comment). Seems like a free win to create a better UX IMO. WDYT?
How?
Leveraging
@wordpress/icons.Testing Instructions
Screenshots or screencast