-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor: fix padding and margin visualizer positioning #43971
Merged
talldan
merged 4 commits into
trunk
from
fix/padding-margin-visualizer-placement-in-site-editor
Sep 8, 2022
Merged
Site editor: fix padding and margin visualizer positioning #43971
talldan
merged 4 commits into
trunk
from
fix/padding-margin-visualizer-placement-in-site-editor
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not receive a frame offset
talldan
added
[Type] Bug
An existing feature does not function as intended
[Feature] UI Components
Impacts or related to the UI component system
labels
Sep 8, 2022
jasmussen
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
67 tasks
ntsekouras
reviewed
Sep 8, 2022
ntsekouras
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan! 💯
talldan
deleted the
fix/padding-margin-visualizer-placement-in-site-editor
branch
September 8, 2022 10:31
Thank you Dan 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #41823
TLDR - Ensures
frameOffset
is not applied for popovers that render inline in the site editor's iframe.Longer explanation:
The site editor has its content within an iframe, and usually most popovers (like the block toolbar) render in the main document. An x/y offset needs to be applied to these popovers so that they're in the correct position on the screen.
There are two situations where this offset doesn't need to be applied. If the popover and its anchor/reference are both not in the iframe (for example, a popover for the block inspector). Or if the popover and its anchor/reference are both in the iframe. The latter is the situation for the padding margin visualizers—they need to be rendered in the site editor's iframe so that they have access to the padding/margin CSS variables for content. But they were still incorrectly receiving the iframe offset.
How?
Adds an extra check to see if the popover and its reference/anchor element are in the same document. This required gaining access to the floating element's owner document, which adds a little bit of extra code.
Testing Instructions
Screenshots or screencast
Before
After