Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make global styles data filterable #44015

Merged
merged 10 commits into from
Sep 13, 2022
Merged

Make global styles data filterable #44015

merged 10 commits into from
Sep 13, 2022

Commits on Sep 12, 2022

  1. Make global styles data filterable

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4d160b0 View commit details
    Browse the repository at this point in the history

  2. Add new gutenberg_merge_theme_json function to act as public API

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    7fcbf75 View commit details
    Browse the repository at this point in the history

  3. Filter: make them to use raw theme.json data instead of a WP_Theme_JS… 

    …ON object
    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6e7a6c3 View commit details
    Browse the repository at this point in the history

  4. Provide smart defaults for when the function runs in a filter

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    e80c7b6 View commit details
    Browse the repository at this point in the history

  5. Document helper function

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    a923703 View commit details
    Browse the repository at this point in the history

  6. Fix blocks data

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    4cffa5d View commit details
    Browse the repository at this point in the history

  7. Clear comment

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    60de8c8 View commit details
    Browse the repository at this point in the history

  8. Add global_styles_user filter

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    a5dddc3 View commit details
    Browse the repository at this point in the history

  9. Create a WP_Theme_JSON_Data structure 

    that replaces the use of gutenberg_theme_json_merge( $existing, $incoming )

People have to use this object instance to filter the theme.json by doing

	$theme_json->update_with( $new_data )

The reason for doing this is that we don't want people to interact
directly with the theme.json array, as it may change, forcing
consumers to update their code.
    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c340a37 View commit details
    Browse the repository at this point in the history

  10. Fix lint issues

    @oandregal
    oandregal committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    23df722 View commit details
    Browse the repository at this point in the history