Document new global styles filters #44111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
oandregal
added
Needs User Documentation
fabiankaegy
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
The guide you've added is very clear and useful! Thanks for adding it :)
I have one question about the APIs that might be a good addition to the docs. But it's not a blocking thing at all.
Do the filters get applied both on the frontend of the site and in all the various editors?
|
Excellent work @oandregal. |
Yes, they run once for every context that uses global styles & settings data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR documents the new global styles filters introduced at #44015
Why?
We want them to be discoverable by authors.
How?
Adds a new page to the hooks reference section of the block editor handbook.
Test
See live document.