UnitControl: fix exhaustive-deps warnings #44161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
44 tasks
|
Size Change: +4 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
mirka
reviewed
Sep 15, 2022
| @@ -100,7 +100,7 @@ function UnforwardedUnitControl( | |||
| if ( parsedUnit !== undefined ) { | |||
| setUnit( parsedUnit ); | |||
| } | |||
| }, [ parsedUnit ] ); | |||
| }, [ parsedUnit, setUnit ] ); | |||
There was a problem hiding this comment.
Ooh, TIL about this useControlledState thing. Looks useful. I just saw the same pattern in ToggleGroupControl, but without using this utility hook.
There was a problem hiding this comment.
Yup!
And there's also useControlledValue 🤦 It would be good to see if we can use only one implementation across the whole package
I can look into it and see what happens! |
ciampo
force-pushed
the
fix/unit-control-exhaustive-deps
branch
from
d88f29d to
a4324af
Compare
Done in a4324af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #41166
Fix all exhaustive-deps warnings on the
UnitControlcomponent.Why?
See #41166 for more context
How?
Add missing deps on the web component, add eslint-disable comments on the native component
Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/unit-control/and make sure that no warnings are printed