-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover: convert unit tests to TypeScript and modern RTL assertions #44373
Conversation
afterEach( () => { | ||
if ( document.activeElement ) { | ||
document.activeElement.blur(); | ||
} | ||
} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not necessary anymore
|
||
it( 'should allow focus-on-open behavior to be disabled', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test has been split into two separate tests (should focus the popover by default when opened
, should allow focus-on-open behavior to be disabled
)
79791c9
to
7c038e5
Compare
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
LGTM!
✅ No type or build errors
✅ Unit tests all pass
✅ Tests and code changes make sense
What?
Part of #35744
Part of #42770
Why?
See #35744
How?
PositionToPlacementTuple
,PlacementToAnimationOriginTuple
,PlacementToInitialTranslationTuple
)document.body
)act
calls (no more necessary)Testing Instructions