Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap gradient colors from "background" to "background-image" #44413

Closed
wants to merge 1 commit into from

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 23, 2022

What?

Changes gradient color to use background-image instead of background.
Closes #32787
Partial for #42105

Why?

-To enable using background effects like background-clip, for detailed example please see #32787
-To differentiate the solid background color from the gradient background color

How?

Testing Instructions

Activate a theme that has a default gradient for the body set in theme.json.
In the browser console, view the Styles source; confirm that the body tag has
background-image: (the selected gradient). and not background: (the selected gradient)

Screenshots or screencast

@carolinan carolinan closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradient backgrounds should be set with background-image instead of background
1 participant