Feature/Respect Image Proportions for the Image Size Control Manual Inputs #44433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a Toggle to optionally constrain the proportions of the ImageSizeControl feature, default false (mimics current WP behaviors).
Why?
Closes: #21918
The classic editor, when inserting images had the option of resizing in the media selector which retrained the image ratio by default (and was actually forced). Inserting an image and changing the aspect ratio (and not cropping the image) is bad practice, and while the Handles on the image retain the aspect ratio, there have been some reports of difficulty on mobile and is generally confusing to have different behaviors between the two interfaces.
This PR adds an image ratio lock and brings the two resize features in line with one another, though provides the ability to opt-out if necessary.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2022-09-23.at.5.35.02.PM.mp4