PHP 8.2: remove deprecated callable in Style Engine value functions #44561
Conversation
Switch to array( self::class, '*' ) with the assumption that we won't need to extend WP_Style_Engine and therefore overwrite the get_individual_property_css_declarations method
ramonjd
added
[Type] Bug
ramonjd
added
the
[Priority] High
There was a problem hiding this comment.
Thanks for fixing this up quickly @ramonjd! This LGTM and I smoke tested to make sure that the individual border sides are still working correctly in server-rendered blocks (like Featured Image):
It'd be good to give @aristath a chance to weigh-in on the introduction of final, but this all looks good to me! ✨
There was a problem hiding this comment.
@ramonjd Thanks for getting this set up, all good from me ✅
I can also confirm that the test errors on PHP 8.2, which were introduced by the previous iteration of this class, no longer show: https://github.com/WordPress/wordpress-develop/actions/runs/3148832341/jobs/5119781953#step:19:326
|
I'm late to the party, but I just checked this one to confirm everything looks OK. The code is simple, and this is a small change - I can confirm there are no issues with PHP 8.2 👍 |
Fixes: #44536
Props to @jrfnl for raising the issue and explaining the options.
What?
A sync of the 6.1 Core patch: WordPress/wordpress-develop#3363
Why?
The string syntax for callables will be deprecated in PHP version 9.
8.2 shows a deprecation notice.
See: https://wiki.php.net/rfc/deprecate_partially_supported_callables
See comment: https://core.trac.wordpress.org/ticket/56467#comment:242 for a description of the deprecation notice and explanation.
How?
This PR switches to use to array( self::class, '*' ) and makes the WP_Style_Engine class final with the understanding that we won't need to, nor should we, extend it.
Testing Instructions
Things should work as expected, PHP unit tests should pass.
As for the compat check, PHP Gutenberg doesn't run unit tests against 8.2 so for now, check the 8.2 unit tests logs as described over in WordPress/wordpress-develop#3363