Fix: Focus animation collapse in global style #44800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
Global Styles
|
Size Change: +7 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Thanks for catching this and contributing a fix. I put together a simpler one at #44823 if you don't mind checking. |
|
Thank you for your more optimal suggestion! I would like to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44796
Related to #39717
What?
This PR solves a problem where a scrollbar temporarily appears and does not animate smoothly when the preview area of a global style is focused.
b98c1e14cd1a79aabcb361113eefcda3.mp4
Why?
This problem probably depends on the scrollbar settings in the operating system. With Windows, this problem could be reproduced at any time.
If you are using a Mac, you may be able to reproduce this by changing the scrollbar setting to "Always" after proceeding in the following order:
the Apple menu > System Preferences > General > Show scroll bars
How?
I tried applying
overflow: hidden;style to many elements, but it did not solve the problem completely. Finally, I found a solution by wrapping one of the motion elements placed in absolute with a div tag.This may not be the best way to do it, so I would appreciate your advice.
Testing Instructions
In this PR, confirm that the animation is smooth and without scrollbars when the mouse hovers over the style variation. At least in my Windows OS, both Google Chrome and Firefox animate correctly.