-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid typography: add font size constraints #44993
Merged
ramonjd
merged 12 commits into
trunk
from
update/fluid-typography-with-min-font-size-value-constraint
Oct 18, 2022
Merged
Fluid typography: add font size constraints #44993
ramonjd
merged 12 commits into
trunk
from
update/fluid-typography-with-min-font-size-value-constraint
Oct 18, 2022
Commits on Oct 17, 2022
-
- Adds default minimum font size limits so that text does not become smaller than 14px/0.875rem/0.875em. The consequence will be that all fluid font sizes will be no smaller than 14px/0.875rem/0.875em in any viewport width. - Users may define font-sizes that are smaller than 14px/0.875rem/0.875em. In this case the user-defined font size becomes the minimum. For example if a user defines 9px for a block, then the minimum font size for that block will be 9px. - Min font size should not be greater than max font size. - Round to 3 decimal places (JS) - Rounding computed min and max values
Configuration menu - View commit details
-
Copy full SHA for db8dd97 - Browse repository at this point
Copy the full SHA db8dd97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7027925 - Browse repository at this point
Copy the full SHA 7027925View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e29b5f - Browse repository at this point
Copy the full SHA 7e29b5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b8903 - Browse repository at this point
Copy the full SHA 08b8903View commit details -
Configuration menu - View commit details
-
Copy full SHA for 087f78a - Browse repository at this point
Copy the full SHA 087f78aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8d80b4 - Browse repository at this point
Copy the full SHA c8d80b4View commit details -
Ensure that rem units are used when calculating min and max boundarie…
…s in em This is to keep it consistent with the original formula and ensure the fluid argument in clamp is working off a size relative to :root Fixing formatting and grammar Rolling back renaming $preset to $font_size in preference to a follow up. Do not clamp value if there is no min size and the font size is less than 14px
Configuration menu - View commit details
-
Copy full SHA for f45b4a5 - Browse repository at this point
Copy the full SHA f45b4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9222dce - Browse repository at this point
Copy the full SHA 9222dceView commit details
Commits on Oct 18, 2022
-
For font sizes of < 14px that have no defined minimum sizes, use the …
…font size to set the floor of the clamp() value.
Configuration menu - View commit details
-
Copy full SHA for df6c71b - Browse repository at this point
Copy the full SHA df6c71bView commit details -
Removing max < min check. It wasn't there before. It can be a follow …
…up if required as it requires extra logic.
Configuration menu - View commit details
-
Copy full SHA for aa2ddf7 - Browse repository at this point
Copy the full SHA aa2ddf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b65a8b6 - Browse repository at this point
Copy the full SHA b65a8b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7a01f8 - Browse repository at this point
Copy the full SHA b7a01f8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.