-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigate regions backwards for macOS Firefox and Safari. #45019
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
716ecc2
Fix navigate regions backwards for macOS Firefox and Safari.
afercia 464e78b
Add changelog entry.
afercia 2238c73
Fix conflicts.
alexstine 8a5d9f6
Add Playwright E2E for catching regressions in all 3 browsers.
alexstine 5b9bc68
Merge branch 'trunk' into fix/navigate-regions-shift-backtick
ciampo e5109ef
Adjust the test to cover browsers event.key inconsistency.
afercia 4667091
Fix typo and add link to PR.
afercia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
test/e2e/specs/editor/various/a11y-region-navigation.spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' ); | ||
|
||
test.describe( 'Region navigation (@firefox, @webkit)', () => { | ||
test.beforeEach( async ( { admin } ) => { | ||
await admin.createNewPost(); | ||
} ); | ||
|
||
test.afterAll( async ( { requestUtils } ) => { | ||
await requestUtils.deleteAllPosts(); | ||
} ); | ||
|
||
test( 'navigates forward and back again', async ( { | ||
editor, | ||
page, | ||
}, testInfo ) => { | ||
// Insert a paragraph block. | ||
await editor.insertBlock( { | ||
name: 'core/paragraph', | ||
attributes: { content: 'Dummy text' }, | ||
} ); | ||
|
||
// Navigate to first region and check that we made it. | ||
await page.keyboard.press( 'Control+`' ); | ||
const editorTopBar = page.locator( | ||
'role=region[name="Editor top bar"i]' | ||
); | ||
await expect( editorTopBar ).toBeFocused(); | ||
|
||
// Navigate to next/second region and check that we made it. | ||
await page.keyboard.press( 'Control+`' ); | ||
const editorContent = page.locator( | ||
'role=region[name="Editor content"i]' | ||
); | ||
await expect( editorContent ).toBeFocused(); | ||
|
||
// Navigate to previous/first region and check that we made it. | ||
// Make sure navigating backwards works also witht he tilde character, | ||
// as browsers interpret the combination of the crtl+shift+backtick keys | ||
// and assign it to event.key inconsistently. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Might be worth adding a link to this PR in the comment here. It's optional though as git blame will do the same 😅 . |
||
if ( testInfo.project.name === 'chromium' ) { | ||
await page.keyboard.press( 'Control+Shift+`' ); | ||
} else { | ||
await page.keyboard.press( 'Control+Shift+~' ); | ||
} | ||
|
||
await expect( editorTopBar ).toBeFocused(); | ||
} ); | ||
} ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: typo