Navigation block e2e tests: default to a list of pages if there are no menus #45070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
changed the title
|
Size Change: +960 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Oct 21, 2022
MaggieCabrera
changed the title
MaggieCabrera
force-pushed
the
add/navigation-playwright-tests
branch
from
8932457
to
93d95f1
Compare
|
Looks like this test needs work since the page list block has changed :D |
MaggieCabrera
changed the title
MaggieCabrera
force-pushed
the
add/navigation-playwright-tests
branch
from
93d95f1
to
9027a6c
Compare
MaggieCabrera
added
the
[Type] Automated Testing
getdave
force-pushed
the
add/navigation-playwright-tests
branch
from
adcd436
to
6b4a65c
Compare
getdave
reviewed
Jan 4, 2023
getdave
reviewed
Jan 4, 2023
scruffian
reviewed
Jan 5, 2023
scruffian
reviewed
Jan 5, 2023
kevin940726
reviewed
Jan 5, 2023
|
@kevin940726 I've tried to wait on specific network requests. But every time I try running these tests the I looked at the artifacts provided by the test runner and no matter what I do the Page List block only becomes visible in the editor after the I'm a bit stuck at this point. Any help or advice would be much appreciated. |
|
Flaky tests detected in 491a297. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3868144494
|
Thanks for the ping! I believe it's because we didn't use I hope it's okay for me to push the change directly on this branch :). |
kevin940726
force-pushed
the
add/navigation-playwright-tests
branch
from
e93488f
to
491a297
Compare
kevin940726
reviewed
Jan 8, 2023
getdave
reviewed
Jan 9, 2023
|
Ok I'm happy with the structure and intent of this test. Requesting final review(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is part of the effort to re work all the navigation block e2e tests and migration to playwright. This is one of the user stories described in #45199
Why?
The navigation e2e tests were really flaky and bottlenecking the github actions. We are rethinking them so they make more sense and are more usable and maintainable.
Testing Instructions
Run
npm run test:e2e:playwright -- editor/blocks/navigation.spec.jsCo-authored-by: Dave Smith 444434+getdave@users.noreply.github.com