Lodash: Refactor away from _.orderBy()
#45146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
|
|
Size Change: +98 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
That is correct, the full support for |
tyxla
force-pushed
the
refactor/lodash-order-by
branch
2 times, most recently
from
c442265 to
663474a
Compare
tyxla
commented
Dec 2, 2022
Comment on lines
+30
to
+35
| // Stable sort: maintaining original array order | ||
| if ( orderA > orderB ) { | ||
| return 1; | ||
| } else if ( orderB > orderA ) { | ||
| return -1; | ||
| } |
There was a problem hiding this comment.
This is how Lodash _.orderBy() works - it maintains original array order, regardless of whether we're sorting in ascending or descending order:
We're opting to keep that behavior and supporting it with a couple of unit tests.
tyxla
added
Mobile App - i.e. Android or iOS
tyxla
requested review from
sgomes,
jsnajdr,
flootr,
swissspidy,
ntsekouras,
aristath,
brookewp,
chad1008,
fabiankaegy,
geriux and
Mamaduka
|
Now that RN has been upgraded to 0.69.4 this is ready for review! |
sgomes
reviewed
Dec 5, 2022
tyxla
force-pushed
the
refactor/lodash-order-by
branch
from
9bebdb4 to
f63990c
Compare
|
Thanks for taking a look @sgomes! Feedback has been addressed and this is ready for another look. |
sgomes
approved these changes
Dec 6, 2022
|
Hey there 👋 I was AFK but I'll check it out today. |
geriux
approved these changes
Dec 7, 2022
|
Thank you, folks 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.orderBy()completely and deprecates the method. We're introducing a custom sorting function to preserve the same behavior as the Lodash function. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're introducing a simple custom sorting function and using it to replace the complex Lodash implementation.
Testing Instructions
/in the editor is sorted the same way.trunk.trunk.