-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: disable nested list drop zone so dropping list items works #45321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +35 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes test well for me 👍
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] List
Affects the List Block
[Feature] Drag and Drop
Drag and drop functionality when working with blocks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Currently it's not possible to rearrange list items by drag and drop.
How?
The simplest solution (this late in the release cycle) is to disable the drop zone for the nested list. Not that nested list items can still be dropped, we're only disabling dropping into the block list for list items, which anyway can only contain one list at most.
Testing Instructions
Create a list and rearrange items with drag and drop. Also try nested list items.
Screenshots or screencast