Edit Post: Improve distraction-free mode notices #45348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
added
[Type] Enhancement
Mamaduka
commented
Oct 27, 2022
| { | ||
| speak: true, | ||
| id: 'core/edit-post/distraction-free-mode/notice', |
There was a problem hiding this comment.
"There can be only one notice with the same ID" - Highlander
Mamaduka
commented
Oct 27, 2022
| { | ||
| speak: true, |
There was a problem hiding this comment.
The snackbars are announced by default; there was no need for this option.
|
Size Change: -29 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Thanks for testing, Dan 🙇 |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR contains the following improvements for the "Distraction Free" mode notice:
idfor notice to avoid flooding the screen with snackbars if you toggle the mode multiple times.sprintf. Since we already know both strings, let's use them. It should make translation easier in some languages.Testing Instructions
Screenshots or screencast