Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify explanation of how 'Convert to Links' works in Page List block #45394

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Clarify explanation of how 'Convert to Links' works in Page List block #45394

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c7b5a2
Clarify explanation of how 'Convert to Links' works
artemiomorales Oct 28, 2022
6068d2e
Remove splitting of translated string
artemiomorales Oct 29, 2022
4dee009
Update string to use createInterpolateElement to ensure proper transl…
artemiomorales Oct 30, 2022
917677d
Simplify and clarify language in Page List edit modal
artemiomorales Nov 4, 2022
fe07bac
Remove tip from modal copy
artemiomorales Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/block-library/src/page-list/convert-to-links-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,13 @@ export default function ConvertToLinksModal( { onClose, clientId } ) {
<Modal
closeLabel={ __( 'Close' ) }
onRequestClose={ onClose }
title={ __( 'Convert to links' ) }
title={ __( 'Customize this menu' ) }
className={ 'wp-block-page-list-modal' }
aria={ { describedby: 'wp-block-page-list-modal__description' } }
>
<p id={ 'wp-block-page-list-modal__description' }>
{ __(
'To edit this navigation menu, convert it to single page links. This allows you to add, re-order, remove items, or edit their labels.'
) }
</p>
<p>
{ __(
"Note: if you add new pages to your site, you'll need to add them to your navigation menu."
'This menu is automatically kept in sync with pages on your site. You can manage the menu yourself by clicking customize below.'
) }
</p>
<div className="wp-block-page-list-modal-buttons">
Expand All @@ -119,7 +114,7 @@ export default function ConvertToLinksModal( { onClose, clientId } ) {
createBlock: create,
} ) }
>
{ __( 'Convert' ) }
{ __( 'Customize' ) }
</Button>
</div>
</Modal>
Expand Down