Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabPanel: add support for manual activation of tabs #45411

Closed
wants to merge 2 commits into from
Closed

TabPanel: add support for manual activation of tabs #45411

wants to merge 2 commits into from

Conversation

ntsekouras
Copy link
Contributor

What?

Resolves: #45390

From the issue:

Currently the TabPanel's tabpanels are activated automatically when the associated tab receives focus (referred to as "Tabs with automatic activation" on the W3C website).

However, as discussed in #44788 (comment) and in #45203 (comment), there instances in which the automatic activation doesn't fit the UX and keyboard navigation needs.

We should look into allowing the TabPanel to support manual activation as well, alongside automatic activation.

@ntsekouras ntsekouras requested review from mirka and ciampo October 31, 2022 08:22
@ntsekouras ntsekouras self-assigned this Oct 31, 2022
@ntsekouras ntsekouras requested a review from ajitbohra as a code owner October 31, 2022 08:22
@codesandbox
Copy link

codesandbox bot commented Oct 31, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@ntsekouras ntsekouras added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [a11y] Keyboard & Focus labels Oct 31, 2022
@ntsekouras ntsekouras mentioned this pull request Oct 31, 2022
Closed
@ciampo
Copy link
Contributor

ciampo commented Oct 31, 2022 •
edited
Loading

As posted in the original issue, let's give the author of ariakit some time to reply to my request to implement manual tab activation directly in ariakit — that would be our favourite option, as it would allow us to refactor the component to ariakit and retain that feature.

We can come back to this in a few days in case we don't hear an answer?

@ntsekouras ntsekouras marked this pull request as draft November 1, 2022 08:03
@ntsekouras ntsekouras closed this Nov 1, 2022
@alexstine alexstine mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka Awaiting requested review from mirka

@ciampo ciampo Awaiting requested review from ciampo

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ntsekouras ntsekouras

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabPanel: add support for manual activation of tabs
2 participants
@ntsekouras @ciampo