Autocomplete: Fix unexpected block insertion during IME composition #45510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: -1 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
@ellatrix I think this issue should also be checked for other components refactored into |
|
Thank you @t-hamano for investigating and working on a fix!
That's definitely a possibility — would you actually have time to investigate those components, since you are very familiar with the issue and how to reproduce it? Thank you! 🙏 |
|
@ciampo |
|
@t-hamano Thank you so much for flagging! I'll also add Modal to the list of confirmed affected components — if there's some kind of text input in the modal and somebody hits Esc to escape out of IME composition, the modal will close. Could you fix that too, if you're addressing them all together? 🙏 I fear that this will become a common pitfall as people start switching from 📌 In short: When listening to key events that potentially fire from text inputs, |
Oh, it wasn't just the Enter key that should be considered. I would like to address them as well 👍 |
Mamaduka
added
[Type] Bug
This was referenced Nov 8, 2022
t-hamano
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #45496
Please refer to the issue for details and causes of this problem.
What?
This PR fixes a problem in inserting a block using the slash key, where the Enter key to confirm input causes an unexpected block to be inserted.
Why?
Details are given in the issue comments, but for example, in Japanese, we press the Enter key after selecting a character from the candidates to confirm the input.
In #43432,
event.keyCodewas replaced byevent.code. But I confirmedevent.codedetects the Enter key to confirm the input, resulting in the unintended insertion of a block.How?
I found that
event.keyis valid: any keystroke before the input is confirmed, including the Enter key, returns the stringProcess.Testing Instructions
This PR may be difficult to test because it requires Japanese input, see "Step-by-step reproduction instructions" in #45496.