-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reposition navigation selector #45555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
draganescu
changed the base branch from
trunk
to
try/list-view-navigation-block
November 4, 2022 13:16
draganescu
added
[Type] Enhancement
A suggestion for improvement.
[Block] Navigation
Affects the Navigation Block
labels
Nov 4, 2022
draganescu
requested review from
talldan,
scruffian,
MaggieCabrera and
getdave
November 4, 2022 13:17
Size Change: +312 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
try/reposition-navigation-selector
branch
from
November 4, 2022 13:55
9e44b71
to
11d08b9
Compare
scruffian
force-pushed
the
try/list-view-navigation-block
branch
from
November 7, 2022 21:38
c790e89
to
7ee8575
Compare
scruffian
reviewed
Nov 8, 2022
scruffian
reviewed
Nov 8, 2022
scruffian
force-pushed
the
try/list-view-navigation-block
branch
from
November 8, 2022 21:17
7ee8575
to
18c01bb
Compare
scruffian
force-pushed
the
try/reposition-navigation-selector
branch
from
November 8, 2022 22:18
b666134
to
f2bdbfb
Compare
scruffian
reviewed
Nov 8, 2022
packages/block-editor/src/components/off-canvas-editor/block.js
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Nov 8, 2022
packages/block-editor/src/components/off-canvas-editor/block.js
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Nov 8, 2022
scruffian
reviewed
Nov 8, 2022
scruffian
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a spin off from #44534.
Why?
Because it is a secondary action to menu editing, and to accommodate the presence of a full list view in the navigation block inspector, the navigation selector's impact has to be reduced.
How?
Testing Instructions
Screenshots or screencast
navigation-off-canvas-editing-selector-moved.mp4