WIP: Attempt to fix partial select + scroll jumping in iOS #45642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +18.3 kB (+1%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/ios-partial-selection
branch
from
876dbdd
to
3466d7e
Compare
|
Closing in favour of #63671. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #33198.
Fixes #16206.
Fixes #28682.
Also enables tap+hold caret movement across blocks on iOS.
Just running some tests...
Why?
How?
Testing Instructions
Screenshots or screencast
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2022-11-09.at.17.22.47.mp4
RPReplay_Final1668540948.mp4
RPReplay_Final1668541009.mp4