NavigatorScreen
: satisfy exhaustive-deps
eslint rule
#45648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure
NavigatorScreen
satisfy theexhaustive-deps
eslint ruleWhy?
Part of the effort in #41166 to apply the
exhaustive-deps
eslint rule to the components packageHow?
In the
useEffect
call we're manipulating thelocation
object (stored in context) by settinghasRestoredFocus
to a boolean value. Due to that assignment the exlint rule expects the wholelocation
object to be a dependency of theuseEffect
call which isn't what we want. Therefore we use a workaround by storing thelocation
object in reflocationRef
and access/write to it that way.Testing Instructions
npx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/navigatior/navigator-screen
navigator
unit tests still passNavigator
component stories and/or docs still work as expectedScreenshots or screencast