Fix: Button block text alignment. #45663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
|
|
Size Change: +145 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/button-block-text-alignment
branch
from
e4f0d73
to
b60d7fd
Compare
jorgefilipecosta
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
bangank36
reviewed
Nov 9, 2022
| ...otherAttributes, | ||
| className: classnames( | ||
| otherAttributes.className, | ||
| 'align' + attributes.align |
There was a problem hiding this comment.
I think we should use literal template for consistency, how do you think?
`align${ attributes.align }`
bangank36
reviewed
Nov 9, 2022
jorgefilipecosta
force-pushed
the
fix/button-block-text-alignment
branch
from
b60d7fd
to
a83d534
Compare
|
Nice, fast work, already merged. I can now do this:
That is, Buttons justifies right, button is an explicit width, and text-left-aligned. Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44614
The button block had a block alignment control for legacy reasons added before the buttons block existed. The block alignment control does not make sense anymore when the block is nested inside buttons and does not work as expected.
This PR removes the block alignment control, and adds a new text alignment control that allows results that were not previously possible.
cc: @jasmussen
Testing
I pasted the following code on the block editor:
I verified the result in both editor and front-end of the site was this one:
I pasted the legacy button block markup on the editor:
I verified the result was this one, and there were no errors: