Perf tests: Store test run results as artifact #45747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
6 tasks
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
4 times, most recently
from
b5e4a52
to
6a0b835
Compare
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
6a0b835
to
b5605f6
Compare
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
b5605f6
to
cca03d3
Compare
|
Flaky tests detected in 921e18d9ffbbd1b431fe35ff8a7c56c91c3f639e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4126349596
|
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
2 times, most recently
from
ef30b6e
to
42427be
Compare
|
@noisysocks were you and I talking about adding this? if not I need to find whoever it was. |
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
42427be
to
df6e7ae
Compare
dmsnell
commented
Feb 7, 2023
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
8075cbb
to
d3e6110
Compare
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
d3e6110
to
de95080
Compare
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
de95080
to
e846da8
Compare
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
e846da8
to
bd75f0d
Compare
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
bd75f0d
to
921e18d
Compare
In this commit we're storing the raw results of all the performance test runs as an artifact in GitHub Actions so that we can perform more extensive analysis outside of workflow runs. For every _round_ of testing we end up with a copy of the results in a JSON file with the branch ref, the test suite name, and the test run index in its name. This makes it possible to analyze each run separately without making it hard to analyze everything together.
dmsnell
force-pushed
the
tests/store-perf-test-results
branch
from
921e18d
to
0f177df
Compare
DaisyOlsen
added
the
GitHub Actions
juanmaguitar
added
the
[Type] Build Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Stores raw data collected during Performance Test CI workflow as an artifact for further external analysis.
Why?
It's hard to extract information from a test the way we currently refine that information within the test run and log it to
stdoutwithin the test runner.Storing the raw data gives us chance to play with the data and explore it outside of a predefined way in the code and lets us change our analysis questions without having to rerun an experiment or re-collect the data.
How?
In this commit we're storing the raw results of all the performance test
runs as an artifact in GitHub Actions so that we can perform more extensive
analysis outside of workflow runs.
For every round of testing we end up with a copy of the results in a JSON
file with the branch ref, the test suite name, and the test run index in its
name. This makes it possible to analyze each run separately without making
it hard to analyze everything together.
This is accomplished by adding a new step in the Performance Tests CI workflow config.
Testing Instructions
There are no functional or visual changes to Gutenberg in this PR. What should change is that a new artifact should appear on the Performance Tests CI workflow. Verify that those results appear, that the artifact is stored as an archive of the various test runs.
How to find results