-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Off Canvas Navigation Editor: Add Convert To Links Modal #45984
Closed
+233
−35
Closed
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
42f6a2c
Rebased: Initial work on nav edit button
0a29db5
Lint
6f9434d
Remove extra dependency
430fe3e
Hide edit button from non-automenus
d3db5d3
Lint
2560b0d
Ongoing work to decouple core-data
getdave 29331c4
Fetch pages via block editor settings
getdave 865b4fa
Revert additional of core-data dependency
getdave 076e9e7
Revert core data dep in block editor package
getdave 47d7381
Update Convert Modal
23f61be
Rebased: Initial work on nav edit button
3061b43
Lint
a8e93cc
Remove extra dependency
6aebd4c
Hide edit button from non-automenus
d9ff62e
Lint
77f1643
Ongoing work to decouple core-data
getdave 1c60ea0
Fetch pages via block editor settings
getdave 0136c51
Revert additional of core-data dependency
getdave c8efdb3
Revert core data dep in block editor package
getdave 5bd0cfc
Update Convert Modal
411a961
Partial fix for post-convert edit button
d30e4a5
Merge branch 'add/navigation-off-canvas-edit' of https://github.com/W…
a7410e0
Cleanup
d970deb
Fix block selection
8e44721
Merge branch 'trunk' into add/navigation-off-canvas-edit
ba00268
Refactor
997186f
Fix Convert Modal in Post Editor
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'trunk' into add/navigation-off-canvas-edit
Conflicts: packages/block-editor/src/components/off-canvas-editor/block-edit-button.js
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I feel the
BlockEditButton
is now doing too much and has awareness of too many concepts.Ideally these components need to stay as close to those in the canonical
<ListView>
as possible. This will make our lives much easier if we try to normalise them in the future.To this end I think we should consider
<ConvertToLinksModal>
modal to it's own fileBlockEditButton
as required.We'll still be coupling concepts like Pages to the block editor package (not good) but at least it will be easier to extract and refactor in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the refactored version and let me know what you think. Moving
usePageData
andConvertToLinksModal
to their own files and lifting theonClick
handler made the button small enough to make it irrelevant.