Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPalette: show Clear button even when colors array is empty #46001

Merged
merged 10 commits into from
Nov 26, 2022
Merged

ColorPalette: show Clear button even when colors array is empty #46001

merged 10 commits into from
Nov 26, 2022

Commits on Nov 25, 2022

  1. Render CircularOptionPicker when colors is an empty array

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    05b556b View commit details
    Browse the repository at this point in the history

  2. Fix Storybook errors when colors array is empty

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    0033149 View commit details
    Browse the repository at this point in the history

  3. Move onChange mock inside each test

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    0b30519 View commit details
    Browse the repository at this point in the history

  4. Rename test to it

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    96a66c9 View commit details
    Browse the repository at this point in the history

  5. Extract color constants outside describe scope, rename variables, u… 

    …se less US-centric colors
    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    1ade89a View commit details
    Browse the repository at this point in the history

  6. Add test to avoid regressions on Clear button not showing when `col… 

    …ors` is an empty array
    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    2771725 View commit details
    Browse the repository at this point in the history

  7. Split clear button test into two separate tests

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    fab208c View commit details
    Browse the repository at this point in the history

  8. CHANGELOG

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    b4551ca View commit details
    Browse the repository at this point in the history

  9. Remove initial color logic in Storybook example

    @ciampo
    ciampo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    5be28fb View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Remove unused imports

    @ciampo
    ciampo committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    b537237 View commit details
    Browse the repository at this point in the history