Navigation Submenu: Use a different icon for the submenu when in the list view #46075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
draganescu,
getdave,
MaggieCabrera and
ajlende
|
|
|
Size Change: +205 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
getdave
reviewed
Nov 28, 2022
Comment on lines
+67
to
+69
| if ( block.name === 'core/navigation-submenu' ) { | ||
| blockInformation.icon = customLink; | ||
| } |
There was a problem hiding this comment.
I think as and when we do this we need to commit to making a follow up Issue.
getdave
reviewed
Nov 29, 2022
There was a problem hiding this comment.
I tested this and it works 🎉 . However...
I'm concerned about yet more coupling of the block editor package to specific blocks.
I'm ok with shipping this as a quick fix, but we need to have a follow up PR to try and invert the control here a bit as I describe in the specific comments below. There is already a pattern in place for labels so we could do something similar for icons.
Basically the control of the icon display should be the block's responsibility. We just need to give the block the information it requires.
Let me know your thoughts on whether you'd like to:
- ship it and commit to follow ups
- do the work now to avoid the coupling
We can discuss and merge acccordingly.
Comment on lines
+64
to
+66
| // This is a very annoying kind of exception. | ||
| // Maybe we need to have a config that allows blocks | ||
| // to have a different icon in the list view? |
There was a problem hiding this comment.
Let's do some dependency inversion on this.
I think we could consider something akin to __experimentalLabel.
Basically I'm suggesting a way to dynamically fetch the icon which the block is responsible for defining. Perhaps by passing in a context we can allow the block to determine which icon to display.
__experimentalIcon( attributes, { context } ) {
const { content, level } = attributes;
if ( context === 'list-view' && content ) {
// return the submenu icon
}
return // standard icon
},
getdave
reviewed
Nov 29, 2022
| // This is a very annoying kind of exception. | ||
| // Maybe we need to have a config that allows blocks | ||
| // to have a different icon in the list view? | ||
| if ( block.name === 'core/navigation-submenu' ) { |
There was a problem hiding this comment.
We should track this in #46166 if it goes ahead "as is".
|
I don't think this approach is right. I left some more thoughts here: #46065 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the icon for the submenu block in the navigation list view
Fixes #46065
Why?
Because this block is also a link, it makes more sense to use a link icon.
How?
By adding a per-block exception in the list view. This is obviously not an ideal solution, but maybe this is ok while the off canvas editing experience is still an experiment? Can we return to it after we decide whether to proceed with the experiment?
Testing Instructions
Screenshots or screencast