Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate core-settings #46176

Closed
wants to merge 1 commit into from

Conversation

alvitazwar
Copy link
Contributor

What?

Based on #38570, part of #38851. Migrate core-settings.test.js

Why?

See #38570 for its background and rationale.

This is split into a new PR for easier review.

How?

See #38570 for the proposed migration steps.

Testing Instructions

npm run test:e2e:playwright /test/e2e/specs/editor/various/core-settings-test.spec.js

Screenshots or screencast

Screen.Recording.2022-10-26.at.6.40.19.PM.mov

@skorasaurus skorasaurus added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label May 1, 2023
@alvitazwar
Copy link
Contributor Author

@Mamaduka Can you please check this?

@t-hamano
Copy link
Contributor

Sorry for the delay in confirming this PR. It seems that this test was migrated by #57581.

I would like to close this PR, but thank you for your efforts!

@t-hamano t-hamano closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants