List View: Use default parameters instead of defaultProps #46266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: +99 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Dec 2, 2022
| @@ -82,7 +82,7 @@ const countReducer = | |||
| function ListViewBranch( props ) { | |||
| const { | |||
| blocks, | |||
| selectBlock, | |||
| selectBlock = () => {}, | |||
There was a problem hiding this comment.
Does it make sense to declare this as a constant outside of the component, so it won't be redeclared on every re-render that doesn't have a selectBlock prop?
Similar to how it's done here:
There was a problem hiding this comment.
Sounds good I will push the update in few minutes.
Btw, I've seen both patterns used in the codebase. Example:
gutenberg/packages/components/src/form-token-field/index.tsx
Lines 52 to 54 in 8c44ccb
There was a problem hiding this comment.
True! I see those as potential optimizations we can do in the future.
packages/block-editor/src/components/off-canvas-editor/branch.js
Outdated
Show resolved
Hide resolved
Mamaduka
commented
Dec 2, 2022
Comment on lines
-7
to
-9
| /** | ||
| * Internal dependencies | ||
| */ |
There was a problem hiding this comment.
Not related to this change. Just found a duplicate comment and removed it.
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…46266) * List View: Use default parameters instead of defaultProps * Use 'noop' with a stable reference * Remove duplicate comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates
ListViewBranchto use ES6 default function parameters instead ofdefaultProps.Why?
All other defaults are defined using this method, and
defaultPropsfor the functional components is getting deprecated. See facebook/react#25699.Testing Instructions
CI checks are green.