Site Editor: Move the edit button on top of the frame #46272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
12 tasks
|
Size Change: +129 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
In light of #45100 I think this move makes sense. It's very disorienting for the edit button to be omnipresent, but also constantly moving as you navigate the drilldown. The proximity to the frame makes it much more apparent what will be edited as well.
I think the 32px height might be a bit small when it comes to adding the entity name / url widget, but we can address that when we get there :)
|
closing this in favor of #46700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #36667
What?
After the initial implementation of the site editor "frame", there has been some feedback that the "edit" button is not visible and not well placed. Per some designs in #44770 this PR moves the edit button on top of the frame.
For now I've just moved the button, but we may be adding more information like the template name.