-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permalink: Hide edit field for users without publishing capabilities #46361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
[Feature] Document Settings
Document settings experience
[Feature] Permalink
The permalink of a post or page and the experience of setting or editing it
labels
Dec 7, 2022
Size Change: +43 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great and makes sense 👍
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Document Settings
Document settings experience
[Feature] Permalink
The permalink of a post or page and the experience of setting or editing it
Needs User Documentation
Needs new user documentation
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #13857.
PR updates URL popover to hide the slug edit field if a user doesn't have post-publishing capabilities.
Why?
The core doesn't allow contributors to set a post slug and will always use the post title to generate it. So changing it in the editor has no effect.
This is an attempt to match UI to backend logic.
Trac ticket that introduced this logic in core: https://core.trac.wordpress.org/ticket/7805.
How?
Updates
isEditable
to check for the right capabilities as well.Testing Instructions
Screenshots or screencast