Navigation List View: Remove empty cell when there is no edit button #46439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
changed the title
MaggieCabrera
added
[Block] Navigation
MaggieCabrera
requested review from
scruffian,
getdave,
ajlende and
draganescu
|
Size Change: +11 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
remove-off-canvas-empty-cell
branch
from
ca41b20 to
7197903
Compare
ryanwelcher
changed the title
|
This causes an accessibility regression: Nav offcanvas - retain key block options but make disabled with appropriate description #47025 |
scruffian
added a commit
that referenced
this pull request
Jan 11, 2023
This reverts commit 78deee0.
scruffian
added a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #46163
This removes the empty
tdelement when there is no edit button present for the page list items.Why?
The
tdelement was taking extra space and it was forcing horizontal scroll in some cases, making the 3 dot menu hard to reach or even hard to discover.How?
The condition to check if an item is editable is now including the cell and a colspan on the 3 dot menu cell takes care of the issue of the missing cell that would render the HTML invalid.
Screenshots or screencast