ToolTip: Remove knobs in stories #46515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Dec 13, 2022
| { showMessage ? <p>Hello World!</p> : null } | ||
| </> | ||
| ); | ||
| export const DisabledChild = Template.bind( {} ); |
There was a problem hiding this comment.
I think this story can be removed because it's basically just a mock for manual testing (that is already covered in unit tests #35254) 🤔 I'm fine with leaving it in for now though.
There was a problem hiding this comment.
I'm fine with leaving it as well, I guess someone could find it useful.
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 20, 2022
| @@ -17,79 +6,80 @@ import Tooltip from '../'; | |||
| export default { | |||
| title: 'Components/ToolTip', | |||
| component: Tooltip, | |||
| argTypes: { | |||
| delay: { control: 'number' }, | |||
There was a problem hiding this comment.
Should we also add a defaultValue of 700 to keep the default value that was there when we used knobs?
Suggested change
| delay: { control: 'number' }, | |
| delay: { control: 'number', defaultValue: 700 }, |
Feel free to place it in Default.args if that makes more sense for you.
There was a problem hiding this comment.
In general we've been taking the direction of not re-specifying default values in Storybook, so we can showcase the actual defaults that are coming from the component code.
The props table will show descriptions and default values once this is converted to TypeScript, which will also help.
| @@ -17,79 +6,80 @@ import Tooltip from '../'; | |||
| export default { | |||
| title: 'Components/ToolTip', | |||
| component: Tooltip, | |||
| argTypes: { | |||
| delay: { control: 'number' }, | |||
| position: { | |||
There was a problem hiding this comment.
Should we default to top center as we did for the previous version of the story that used knobs?
Suggested change
| position: { | |
| position: { | |
| defaultValue: 'top center', |
| { showMessage ? <p>Hello World!</p> : null } | ||
| </> | ||
| ); | ||
| export const DisabledChild = Template.bind( {} ); |
There was a problem hiding this comment.
I'm fine with leaving it as well, I guess someone could find it useful.
|
Thanks for helping out with reviews @tyxla 🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
What?
Remove the Knobs add-on from
ToolTipstories.Why?
This is now a blocker for supporting npm 8 (#46443).
How?
Just a quick, minimal refactor. Eventually we should leverage TypeScript types once this component is typed properly.
Testing Instructions
npm run storybook:devToolTipcomponent. (Careful, there is also aTooltipcomponent 🙃)