Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation list view: use smaller lock icon #46578

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Navigation list view: use smaller lock icon #46578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e276d7
used smaller lock icon on off canvas editor
MaggieCabrera Dec 15, 2022
791fa2f
reduce size of lock icon on list view too
MaggieCabrera Dec 16, 2022
656f83d
removed repeated css
MaggieCabrera Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/list-view/block-select-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
__experimentalTruncate as Truncate,
} from '@wordpress/components';
import { forwardRef } from '@wordpress/element';
import { Icon, lock } from '@wordpress/icons';
import { Icon, lockSmall as lock } from '@wordpress/icons';
import { SPACE, ENTER } from '@wordpress/keycodes';

/**
Expand Down
7 changes: 6 additions & 1 deletion packages/block-editor/src/components/list-view/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,16 @@

.block-editor-list-view-block-select-button__lock {
line-height: 0;
width: 24px;
width: 16px;
min-width: 24px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that makes them look tiny! we are respecting the space of the container because the SVG is still 24px wide. I'm following Joen's codepen of CSS magic for this :D

height: 16px;
margin-left: auto;
padding: 0;
vertical-align: middle;
display: inline-flex;
justify-content: center;
align-items: center;
overflow: hidden;
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/off-canvas-editor/block-select-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
__experimentalTruncate as Truncate,
} from '@wordpress/components';
import { forwardRef } from '@wordpress/element';
import { Icon, lock } from '@wordpress/icons';
import { Icon, lockSmall as lock } from '@wordpress/icons';
import { SPACE, ENTER } from '@wordpress/keycodes';

/**
Expand Down
1 change: 1 addition & 0 deletions packages/icons/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export { default as listItem } from './library/list-item';
export { default as listView } from './library/list-view';
export { default as lock } from './library/lock';
export { default as lockOutline } from './library/lock-outline';
export { default as lockSmall } from './library/lock-small';
export { default as login } from './library/login';
export { default as loop } from './library/loop';
export { default as mapMarker } from './library/map-marker';
Expand Down
16 changes: 16 additions & 0 deletions packages/icons/src/library/lock-small.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/**
* WordPress dependencies
*/
import { SVG, Path } from '@wordpress/primitives';

const lockSmall = (
<SVG viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg">
<Path
fillRule="evenodd"
clipRule="evenodd"
d="M15 11h-.2V9c0-1.5-1.2-2.8-2.8-2.8S9.2 7.5 9.2 9v2H9c-.6 0-1 .4-1 1v4c0 .6.4 1 1 1h6c.6 0 1-.4 1-1v-4c0-.6-.4-1-1-1zm-1.8 0h-2.5V9c0-.7.6-1.2 1.2-1.2s1.2.6 1.2 1.2v2z"
/>
</SVG>
);

export default lockSmall;