DOM: fix findNext/Previous tabbable if target is not in findFocusable list #46580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -23 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Dec 15, 2022
|
Just seeing this, thank you for working on this fix! TIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The problem is that, when focus is on a scrollable container,
focus.tabbable.findNextfails because the scroll container is not in thefindFocusablelist.indexOfreturns-1, so we fail to slice the list correctly.The solution is to use
compareDocumentPositionto find the previous/next element in the list.Why?
Fixes #45489.
How?
Testing Instructions
Open the inserter in Firefox and try to tab to the list of blocks.
Testing Instructions for Keyboard
Screenshots or screencast