Code Quality: Use <> instead of Fragment #46633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
quality/replace-flagments
branch
from
47347ad
to
91cdd69
Compare
t-hamano
added
[Type] Code Quality
t-hamano
force-pushed
the
quality/replace-flagments
branch
from
91cdd69
to
81919b0
Compare
t-hamano
commented
Dec 18, 2022
|
Size Change: -2 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
ajitbohra,
ellatrix,
tellthemachines,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
Mamaduka
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
LGTM 👍
I think the only time we want to use Fragment is when we might want to pass a key. See: https://beta.reactjs.org/apis/react/Fragment#rendering-a-list-of-fragments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15120
What?
This PR replaces
<Fragment>with<>in the code base and documentation..Why?
My understanding is that it should be recommended that
Fragmentcomponents without props be replaced with<>.How?
I searched the entire project for
<Fragment>and replaced everything that could be replaced.Testing Instructions
Some statements are not replaced in this PR. You will find that some
<Fragments>have not been replaced, but that's because they are explicitly component tested.