E2E: Fix confirmValidDropZonePosition() when dropzone not ready
#46677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Dec 20, 2022
|
Going to ship this, and keep an eye on whether this e2e test will continue to be flaky. Thanks, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR attempts to improve
confirmValidDropZonePosition()in order to fix the flaky test reported in #46463.Fixes #46463.
Why?
See #46463.
How?
Since
confirmValidDropZonePosition()is being polled for, we're making it returnfalseif the drop zone bounding box isnull. That way it won't throw an error and will just continue polling. This brings the test back closer to how it worked with regard to the polling behavior prior to #46187.Testing Instructions
Verify all tests are green.