Edit-post site logo: Fix focus style. #46733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +8 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The site logo (the W button in the top left corner) has an incorrect focus style in the post editor, being 1px off below:
That's because the height of the toolbar is 60px tall, plus 1px border. This PR fixes it by adding that extra 1px border to the bottom positioning of the focus style:
This issue is different in the site editor, and not a place to fix it at this point, as the site logo there is currently a little bit in flux. See also #46700
Testing Instructions
Set focus on the W back button in the post editor, and observe a focus style that is square.